Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastdom dependency was not used #5513

Closed
kristw opened this issue Jul 28, 2018 · 1 comment
Closed

fastdom dependency was not used #5513

kristw opened this issue Jul 28, 2018 · 1 comment
Labels
inactive Inactive for >= 30 days

Comments

@kristw
Copy link
Contributor

kristw commented Jul 28, 2018

Superset version

Current

Expected results

nvd3 took advantage of fastdom as intended by this PR
#3947

Actual results

fastdom has never been imported into the js code, so window.fastdom does not exist and nvd3 in superset did not get the benefits.

From nvd3 https://github.com/novus/nvd3/blob/master/src/dom.js

nv.dom.write = function(callback) {
	if (window.fastdom !== undefined) {
		return fastdom.mutate(callback);
	}
	return callback();
};

To-do

Either remove fastdom from dependency or add import 'fastdom';

@stale
Copy link

stale bot commented Apr 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 10, 2019
@kristw kristw closed this as completed Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

1 participant