Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #4490 breaks new slice creation #4537

Closed
2 of 3 tasks
Pek1s opened this issue Mar 5, 2018 · 0 comments · Fixed by #4538
Closed
2 of 3 tasks

PR #4490 breaks new slice creation #4537

Pek1s opened this issue Mar 5, 2018 · 0 comments · Fixed by #4538

Comments

@Pek1s
Copy link
Contributor

Pek1s commented Mar 5, 2018

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

master (4135854)

Expected results

When creating new Slice through /slicemodelview/add, Superset should allow selecting the datasource and visualization type and then continue into slice editor.

Actual results

Submitting the form causes TypeError exception and user is unable to get into slice editor.

superset/views/core.py", line 1199, in datasource_info causes the exception because there isn't datasource defined in encoded JSON that is provided as query parameter.

Possible fix

React frontend is still conforming partially old API and the changes #4490 are not propagated fully into frontend.
Frontend should inject the form parameters into form_data-param

EDIT: #4538 fixes this problem. See the PR

Steps to reproduce

  1. Go to: /slicemodelview/add
  2. Select any datasource
  3. Select any visualization type
  4. Click Create new slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant