Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explore] Stop button for queries doesn't work? #4417

Closed
vylc opened this issue Feb 13, 2018 · 6 comments
Closed

[Explore] Stop button for queries doesn't work? #4417

vylc opened this issue Feb 13, 2018 · 6 comments
Labels
inactive Inactive for >= 30 days

Comments

@vylc
Copy link

vylc commented Feb 13, 2018

Stop button functionality, when pressed:
(1) Cancel query on DB side
(2) Reset explore view to state before query was run
(3) Currently, when query is running, user is allowed to modify selections on left hand nav
(a) When stop button is depressed, should stop current query and persist these selections
(b) Could also not allow user to change selections when query is being run (ie. grey out selectors)
I think a is preferable, but both are acceptable.

  • [ x] I have checked the superset logs for python stacktraces and included it here as text if any
  • [ x] I have reproduced the issue with at least the latest released version of superset
  • [ x] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

Expected results

Actual results

Steps to reproduce

@mistercrunch
Copy link
Member

fixed here:
#4301

@graceguo-supercat
Copy link

#4301 only stop query in front-end, the query is still running in DB side (but browser won't wait for response). It will be good feature to stop query on DB side.

@stale
Copy link

stale bot commented Apr 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 11, 2019
@stale stale bot closed this as completed Apr 18, 2019
@dpnsh
Copy link

dpnsh commented Aug 9, 2021

@vylc were you able to solve this issue ?

@saurabh3091
Copy link
Contributor

saurabh3091 commented Feb 17, 2022

@dpnsh I figured the issue. You can fix this issue by adding

while polled.operationState in unfinished_states:
    session.refresh(query)

inside this while loop. I will create a PR for that in superset.

while polled.operationState in unfinished_states:

@saurabh3091
Copy link
Contributor

Can be tracked through this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

5 participants