-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explore] Stop button for queries doesn't work? #4417
Comments
fixed here: |
#4301 only stop query in front-end, the query is still running in DB side (but browser won't wait for response). It will be good feature to stop query on DB side. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue |
@vylc were you able to solve this issue ? |
@dpnsh I figured the issue. You can fix this issue by adding
inside this while loop. I will create a PR for that in superset. superset/superset/db_engine_specs/hive.py Line 335 in 398a01f
|
Can be tracked through this issue. |
Stop button functionality, when pressed:
(1) Cancel query on DB side
(2) Reset explore view to state before query was run
(3) Currently, when query is running, user is allowed to modify selections on left hand nav
(a) When stop button is depressed, should stop current query and persist these selections
(b) Could also not allow user to change selections when query is being run (ie. grey out selectors)
I think a is preferable, but both are acceptable.
Superset version
Expected results
Actual results
Steps to reproduce
The text was updated successfully, but these errors were encountered: