fix: FacePile is requesting avatars when SLACK_ENABLE_AVATARS is false

[michael-s-molina]

SUMMARY

#27849 introduced the Slack Avatar integration which augments the FacePile component with avatar images. This PR fixes an issue where the avatar images were being requested even when SLACK_ENABLE_AVATARS is False, generating unnecessary requests.

TESTING INSTRUCTIONS

Check that avatar images are not requested if SLACK_ENABLE_AVATARS is False.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.56%. Comparing base (76d897e) to head (3849fc6).
Report is 1094 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #30156       +/-   ##
===========================================
+ Coverage   60.48%   70.56%   +10.07%     
===========================================
  Files        1931     1976       +45     
  Lines       76236    79485     +3249     
  Branches     8568     9054      +486     
===========================================
+ Hits        46114    56085     +9971     
+ Misses      28017    21171     -6846     
- Partials     2105     2229      +124     

Flag	Coverage Δ
hive	48.86% <ø> (-0.30%)	⬇️
javascript	58.38% <100.00%> (+0.67%)	⬆️
mysql	76.64% <ø> (?)
postgres	76.74% <ø> (?)
presto	53.41% <ø> (-0.39%)	⬇️
python	83.65% <ø> (+20.16%)	⬆️
sqlite	76.20% <ø> (?)
unit	60.39% <ø> (+2.76%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[villebro]

LGTM, thanks for the fix

[mistercrunch]

Thanks for the improvement, this is better than the solution I had -> the backend would disregard the call and return a 204 when the flag was disabled https://github.com/apache/superset/blob/master/superset/views/users/api.py#L147-L164

Better to not call at all in the first place though! I didn't know an easy way to get access to the FF from the component...