Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superset can not know the string/varchar columns from impala table #2973

Closed
zhouzach opened this issue Jun 15, 2017 · 8 comments
Closed

superset can not know the string/varchar columns from impala table #2973

zhouzach opened this issue Jun 15, 2017 · 8 comments

Comments

@zhouzach
Copy link

zhouzach commented Jun 15, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • [* ] I have checked the superset logs for python stacktraces and included it here as text if any
  • [ *] I have reproduced the issue with at least the latest released version of superset
  • [* ] I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.18.4

Expected results

when Add Sqla Table, superset can get all right columns from impala table

Actual results

when Add Sqla Table, superset can not know the string/varchar columns from impala table

Steps to reproduce

1.have impala table:

image

2.Add Database from impala

3.Add Sqla Table
edit table->list table column, I find that the string/varchar columns can not be known by superset

image

@xrmx
Copy link
Contributor

xrmx commented Jun 15, 2017

Sure this is an issue in superset and not in the sqlalchemy dialect / plumbing?

@zhouzach
Copy link
Author

@xrmx I am a superset beginner, no idea about the problem.Do you use superset on impala table that has the string/varchar columns and succeed?

@xiaoyugit
Copy link
Contributor

i had the same issue with 0.18.5

@jxb45
Copy link

jxb45 commented Jul 26, 2017

Same issue. I'm on 0.18.5 as well. This maybe another issue, but Time Grains don't show for Impala as well.

@mistercrunch
Copy link
Member

I wonder if the UNKOWN value comes out of the SQLAlchemy dialect or if it comes from us here:
https://github.com/apache/incubator-superset/blob/a141695b2b73df1d05d74c8ed8e22341e6e25edc/superset/connectors/sqla/models.py#L586

Do you see stack traces in your log when saving a Impala table? If so please paste it here. If not that means it's coming out as UNKNOWN out of the driver/dialect and needs to be fixed there.

@mistercrunch
Copy link
Member

@JImBurris about time grains, they haven't been contributed yet for Impala. Someone needs to send a PR with a DBEngineSpec with time grains defined for impala, it's as simple as:
https://github.com/apache/incubator-superset/blob/master/superset/db_engine_specs.py#L193

@mistercrunch
Copy link
Member

Here, can someone that has impala test this?
#3225

@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 264 days. Feel free to comment and request for this issue to be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants