Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[explore] disable "granularity" control for non-timeseries visualizations #2750

Closed
3 tasks done
petroswork opened this issue May 11, 2017 · 5 comments · Fixed by #8674
Closed
3 tasks done

[explore] disable "granularity" control for non-timeseries visualizations #2750

petroswork opened this issue May 11, 2017 · 5 comments · Fixed by #8674
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@petroswork
Copy link

petroswork commented May 11, 2017

Make sure these boxes are checked before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if any
  • I have reproduced the issue with at least the latest released version of superset
  • I have checked the issue tracker for the same issue and I haven't found one similar

Superset version

0.17.6

Expected results

Using the timestamp column for the series, I would expect the time grain to apply, so that the series is e.g. weekly.

Actual results

The query executed does not include any statement regarding the time grain and this is visible in the visualization.

Steps to reproduce

Create a distribution bar chart with timestamp series.

@mistercrunch
Copy link
Member

You may want to use the time series bar chart. We should hide the granularity selector on visualizations that are not time series...

@petroswork
Copy link
Author

I used the time series bar chart instead. Wouldn't it be better if there were only one bar chart visualization and the type would change depending on whether the time grain has a value or not?

@mistercrunch
Copy link
Member

Perhaps, though some of the form elements as they exist should get enabled/disabled based on whether granularity is specified or not, and the change management around this change (a database migration script that would alter slices to the new scheme) would be significant.

@mistercrunch mistercrunch changed the title Distribution bar chart - Time grain has no effect [explore] disable "granularity" control for non-timeseries visualizations May 17, 2017
@mistercrunch
Copy link
Member

Notice: this issue has been closed because it has been inactive for 340 days. Feel free to comment and request for this issue to be reopened.

@john-bodley
Copy link
Member

I think this is a valid issue, we should only show granularities for charts types which group-by time (time-series). Having this displayed for non-time-series based charts is misleading.

@john-bodley john-bodley reopened this Nov 26, 2019
@john-bodley john-bodley added the !deprecated-label:bug Deprecated label - Use #bug instead label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants