Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Layer modal doesn't list all table charts when there are more than 100 tables #25421

Closed
2 of 3 tasks
yousoph opened this issue Sep 26, 2023 · 1 comment · Fixed by #27022
Closed
2 of 3 tasks

Comments

@yousoph
Copy link
Member

yousoph commented Sep 26, 2023

When creating a chart, users are able to add Annotation Layers that can be set to be powered by an existing table chart. However, the dropdown selector to specify a chart isn't returning all table charts available in the Workspace.

How to reproduce the bug

  1. Make sure you have over 100 charts (duplicate dashboards to get to 100 more quickly if needed)
  2. Create a new Table Chart -- make sure the name starts with Z to see the bug more easily
  3. Try to use this table chart as an annotation layer source on another chart, like a Mixed chart or a time series chart

Expected results

When searching for a chart when adding annotations, the new chart appears

Actual results

image
The new chart doesn't appear in the chart list

Environment

(please complete the following information):

  • browser type and version:
  • superset version: master
  • python version: python --version
  • node.js version: node -v
  • any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

It seems that the endpoint to fetch the charts is only returning 100 results - there doesn't seem to be pagination and it also doesn't seem to be filtering by viz_type = table, which might also reduce the number of charts that would be returned.

@rusackas
Copy link
Member

Looks kike this one is close to getting closed! Thanks for the help @rtexelm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants