Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

very minor issue, padding between widgets sometimes not working #20303

Closed
csamsel opened this issue Jun 8, 2022 · 5 comments
Closed

very minor issue, padding between widgets sometimes not working #20303

csamsel opened this issue Jun 8, 2022 · 5 comments
Labels
preset:cares Preset cares about this issue

Comments

@csamsel
Copy link

csamsel commented Jun 8, 2022

Screenshot

image

Description

Very minor issue: Sometimes (i think when widgets are arranged both vertically and horizontally), they overlap each other. It's only visible when hovering e.g. over filters so the widget frames are highlighted.

Design input

don't think this one requires specific input :)

@gbusch
Copy link
Contributor

gbusch commented Jun 8, 2022

Some addition to Christian's description (working in the same team):
This happens when using tabs.
The same dashboard with the same charts has vertical padding when it is not in tabs.
As soon as we add tabs and move the charts to one of the tabs, the vertical padding vanishes and it appears as shown above.

@rusackas rusackas added the preset:cares Preset cares about this issue label Jun 13, 2022
@rusackas
Copy link
Member

This is interesting... hopefully we can take a look at it at some point, but I'm not sure if/when it'll get prioritized. Any interest in digging a little deeper and opening a PR, perchance?

@csamsel
Copy link
Author

csamsel commented Jun 13, 2022

unfortunately we are not very good at CSS and JavaScript and quiet busy with usual work, so this is not really a priority for me either.

@gbusch
Copy link
Contributor

gbusch commented Jun 13, 2022

@rusackas Maybe this PR #20366 solves it already?!

@gbusch
Copy link
Contributor

gbusch commented Sep 5, 2022

@csamsel was fixed in the PR above, can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset:cares Preset cares about this issue
Projects
None yet
Development

No branches or pull requests

3 participants