Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Helm Chart] Wrong filename for import_dashboards in documentation and values.yaml #18641

Closed
wiktor2200 opened this issue Feb 9, 2022 · 2 comments
Closed

[Helm Chart] Wrong filename for import_dashboards in documentation and values.yaml #18641

wiktor2200 opened this issue Feb 9, 2022 · 2 comments

Comments

@wiktor2200
Copy link
Contributor

Description

There is wrong filename mentioned in documentation for helm chart deployment.
datasources_init.yaml instead of import_datasources.yaml which is actually loaded in:

superset/helm/superset/values.yaml

Line 346 in 6200977

superset import_datasources -p {{ .Values.extraConfigMountPath }}/import_datasources.yaml

Fix

I've fixed it in # so please review.
@wiktor2200 wiktor2200 mentioned this issue Feb 9, 2022
Merged
9 tasks
@ad-m
Copy link
Contributor

ad-m commented Feb 11, 2022

@wiktor2200 could you confirm that the issue was fixed?

@wiktor2200
Copy link
Contributor Author

wiktor2200 commented Feb 11, 2022 •
edited
Loading

Yes, it was fixed in #18642 in commit: a72fc71
So I'm closing it, thanks for reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ad-m @wiktor2200