Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard Editor] Cmd + Z should not revert layout changes when editing chart title #18096

Closed
3 tasks done
ktmud opened this issue Jan 19, 2022 · 3 comments
Closed
3 tasks done
Labels
#bug Bug report dashboard:editmode Related to te Dashboard edit mode inactive Inactive for >= 30 days

Comments

@ktmud
Copy link
Member

ktmud commented Jan 19, 2022

How to reproduce the bug

  1. Go to dashboard edit mode
  2. Make some layout changes. For example, resize a chart.
  3. Click on a chart title to edit it:
    Xnip2022-01-19_11-40-07
  4. Enter something and click on Ctr + Z (Windows) or Cmd + Z (macOS)

Expected results

The input value revert to previous edits. The layout doesn't change.

Actual results

The layout change was reverted but the input value didn't change.

Screenshots

N/A

Environment

Latest master branch

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

N/A

@ktmud ktmud added #bug Bug report dashboard:editmode Related to te Dashboard edit mode labels Jan 19, 2022
@stephenLYZ
Copy link
Member

stephenLYZ commented Jan 22, 2022

Agree. I think it makes sense. And I open this #18137 to improve this behavior.

@stale
Copy link

stale bot commented Apr 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 17, 2022
@rusackas
Copy link
Member

Looks like the fix was merged. Closing this, but happy to re-open if anyone sees this behavior being exhibited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:editmode Related to te Dashboard edit mode inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants