Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart / values.yaml should support specifying ingressClassName #17085

Closed
mrokitka opened this issue Oct 13, 2021 · 1 comment
Closed

Helm chart / values.yaml should support specifying ingressClassName #17085

mrokitka opened this issue Oct 13, 2021 · 1 comment

Comments

@mrokitka
Copy link

The Helm chart / values.yaml file currently only supports specifying an ingress class via the deprecated "kubernetes.io/ingress.class" annotation. The chart should be updated to support specifying ingress class as a property of the ingress section of the yaml file, which will result in the ingressClassName field being written to the spec of the ingress kube resource.

See:
https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation
https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/

@dpgaspar
Copy link
Member

PR from @Jolcik currently on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants