Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native_filter]Filters being put in out of scope when first opening the dashboard #17060

Closed
3 tasks done
michael-s-molina opened this issue Oct 11, 2021 · 4 comments · Fixed by #17084
Closed
3 tasks done
Assignees
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard

Comments

@michael-s-molina
Copy link
Member

Expected results

The scope is calculated correctly when first opening the dashboard.

Actual results

Filters being put in out of scope when first opening the dashboard.

Screenshots

Screen.Recording.2021-10-11.at.3.45.24.PM.mov

Environment

  • browser type and version: Chrome 94.0.4606.71
  • superset version: master

Checklist

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

#17007

@stevetracvc
Copy link
Contributor

I'm curious if that's also related to an issue I've had intermittently... Sometimes, when I open a dashboard, the contents of the dashboard won't load (it only shows the loading Superset animation) until I expand the filters

@junlincc
Copy link
Member

junlincc commented Oct 12, 2021

Screen Shot 2021-10-12 at 11 34 46 AM

cc @jinghua-qa

Would like to see this cosmetic issue get fixed somehow. 😀

@junlincc
Copy link
Member

I'm curious if that's also related to an issue I've had intermittently... Sometimes, when I open a dashboard, the contents of the dashboard won't load (it only shows the loading Superset animation) until I expand the filters

@stevetracvc It sounds problematic, could you provide a screen recording? ideally, open an issue with details if you have not.

@junlincc junlincc changed the title Filters being put in out of scope when first opening the dashboard [native_filter]Filters being put in out of scope when first opening the dashboard Oct 12, 2021
@stevetracvc
Copy link
Contributor

stevetracvc commented Oct 12, 2021

@junlincc
Yea I don't know if it's just something I messed up with some custom tweaks I've done, which is why I haven't opened an issue yet. I've made enough changes that it's probably my fault. I'll try to pay more attention next time and see if I can find an error. It's almost definitely something in the JS getting stuck, which stops the rest of the rendering for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report dashboard:native-filters Related to the native filters of the Dashboard
Projects
None yet
4 participants