Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard][markdown] User can remove markdown component in dashboard view mode #16981

Closed
3 tasks done
graceguo-supercat opened this issue Oct 5, 2021 · 0 comments · Fixed by #17034
Closed
3 tasks done
Assignees
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report dashboard:markdown Related to the markdown component of the Dashboard P2 Priority item - High

Comments

@graceguo-supercat
Copy link

A clear and concise description of what the bug is.

How to reproduce the bug

  1. create new dashboard,
  2. add markdown component
  3. save dashboard
  4. Open dashboard, and hover on the markdown component
  5. you can click trash icon to remove markdown component

Expected results

  • Only in dashboard edit mode can change dashboard layout and components.
  • Only dashboard owner can edit dashboard.

Screenshots

rxSiPpzrw5

Environment

Lastest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

cc @junlincc @jinghua-qa @pkdotson

@graceguo-supercat graceguo-supercat added the #bug Bug report label Oct 5, 2021
@junlincc junlincc added the #bug:regression Bugs that are identified as regessions label Oct 6, 2021
@junlincc junlincc added dashboard:markdown Related to the markdown component of the Dashboard P2 Priority item - High labels Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:regression Bugs that are identified as regessions #bug Bug report dashboard:markdown Related to the markdown component of the Dashboard P2 Priority item - High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants