Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard][error msg] Can we have specific error info in the error title #16938

Closed
jinghua-qa opened this issue Oct 1, 2021 · 3 comments · Fixed by #16959
Closed

[dashboard][error msg] Can we have specific error info in the error title #16938

jinghua-qa opened this issue Oct 1, 2021 · 3 comments · Fixed by #16959
Assignees
Labels
explore:error Related to general errors of Explore good first issue Good first issues for new contributors preset:QA Preset QA team

Comments

@jinghua-qa
Copy link
Member

When user encounter error in dashboard, can we show the specific error information rather than 'Unexpected error'?

For example for Missing dataset error, can we show the error title to bubble up as 'Missing dataset' rather than 'Unexpected error'? It will be easier for user to see specific error right away.

Screen Shot 2021-10-01 at 10 48 24 AM

Screen Shot 2021-10-01 at 10 50 07 AM

@superset-github-bot superset-github-bot bot added the preset:QA Preset QA team label Oct 1, 2021
@junlincc junlincc added good first issue Good first issues for new contributors explore:error Related to general errors of Explore labels Oct 1, 2021
@junlincc
Copy link
Member

junlincc commented Oct 1, 2021

@stephenLYZ 🙏 "Missing dataset" should do

@1nF0rmed
Copy link

1nF0rmed commented Oct 2, 2021

Was wondering why we would need to do so? Doesn't the See more part already give more context if needed in this case?

@stephenLYZ
Copy link
Member

I believe that for user experience the code level error reporting should be blocked and these errors should be placed in the console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
explore:error Related to general errors of Explore good first issue Good first issues for new contributors preset:QA Preset QA team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants