Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute value diff is incorrect #16766

Closed
rubypollev opened this issue Sep 21, 2021 · 3 comments · Fixed by #16930
Closed

Absolute value diff is incorrect #16766

rubypollev opened this issue Sep 21, 2021 · 3 comments · Fixed by #16930
Assignees
Labels
#bug Bug report validation:required A committer should validate the issue

Comments

@rubypollev
Copy link

rubypollev commented Sep 21, 2021

Absolute value diff is t1 - t2 when it should be |t1 - t2|. The absolute value function is not being applied.

diff = df - df2

@rubypollev rubypollev added the #bug Bug report label Sep 21, 2021
@junlincc junlincc added the validation:required A committer should validate the issue label Sep 21, 2021
@zhaoyongjie
Copy link
Member

@rubypollev The absolute function is not necessarily applied to diff results. cc: @junlincc

diff In the tableau
image

@rubypollev
Copy link
Author

Tableau's implementation makes sense. This is a "difference." It can be negative.

Superset's implementation claims this same function is an "absolute difference," though, which it's not:
time_comparison_absolute_difference

An absolute difference is non-negative by definition.

@zhaoyongjie
Copy link
Member

Hi @rubypollev, thanks for your Issue, I will fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report validation:required A committer should validate the issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants