We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute value diff is t1 - t2 when it should be |t1 - t2|. The absolute value function is not being applied.
t1 - t2
|t1 - t2|
superset/superset/viz.py
Line 1434 in 4e3d4f6
The text was updated successfully, but these errors were encountered:
@rubypollev The absolute function is not necessarily applied to diff results. cc: @junlincc
diff In the tableau
diff
Sorry, something went wrong.
Tableau's implementation makes sense. This is a "difference." It can be negative.
Superset's implementation claims this same function is an "absolute difference," though, which it's not:
An absolute difference is non-negative by definition.
Hi @rubypollev, thanks for your Issue, I will fix it asap.
zhaoyongjie
Successfully merging a pull request may close this issue.
Absolute value diff is
t1 - t2
when it should be|t1 - t2|
. The absolute value function is not being applied.superset/superset/viz.py
Line 1434 in 4e3d4f6
The text was updated successfully, but these errors were encountered: