Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqllab] Stop button should kill running query in the database #15402

Closed
koszti opened this issue Jun 27, 2021 · 2 comments
Closed

[sqllab] Stop button should kill running query in the database #15402

koszti opened this issue Jun 27, 2021 · 2 comments
Labels
#bug:performance Performance bugs inactive Inactive for >= 30 days

Comments

@koszti
Copy link
Contributor

koszti commented Jun 27, 2021

Is your feature request related to a problem? Please describe.

SQL Lab has Stop button but it only updates state of superset without actually stopping the database query. Leaving the queries running in the background affect database performance.

Running queries should be killed automatically in the database if the stop button pressed, the browser window closed or navigated to another site.

Describe the solution you'd like

Pressing the stop button in SQL Lab should trigger a mechanism to kill the running query in the database. The same function should be called when the browser windows closed or navigated to another site.

Describe alternatives you've considered

Additional context

@koszti koszti changed the title [sqllab] Stop button should kill/cancel running query in the database [sqllab] Stop button should kill running query in the database Jun 27, 2021
@suddjian suddjian added the #bug:performance Performance bugs label Jun 28, 2021
@stale
Copy link

stale bot commented Apr 30, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Apr 30, 2022
@rusackas
Copy link
Member

Looks like the fix was merged and this was just never closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug:performance Performance bugs inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

3 participants