Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore][Table] Adding sort by without metrics causing unexpected error #13465

Closed
ktmud opened this issue Mar 4, 2021 · 0 comments · Fixed by #13434
Closed

[Explore][Table] Adding sort by without metrics causing unexpected error #13465

ktmud opened this issue Mar 4, 2021 · 0 comments · Fixed by #13434
Labels
explore:sort Related to sorting in Explore test:case

Comments

@ktmud
Copy link
Member

ktmud commented Mar 4, 2021

Expected results

Table chart should allow sort by without metrics.

Actual results

Table chart is not able to handle sort by without metrics.

Screenshots

How to reproduce the bug

  1. Go create a new Table viz
  2. Add a Group by column
  3. Add a sort by metric
  4. Run the query

Environment

Latest master and an example dataset on Postgres.

Additional context

Could be related to #13426 #13423 and #13228
@ktmud ktmud added the #bug Bug report label Mar 4, 2021
@ktmud ktmud mentioned this issue Mar 4, 2021
Merged
6 tasks
@junlincc junlincc added test:case explore:sort Related to sorting in Explore and removed #bug Bug report labels Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
explore:sort Related to sorting in Explore test:case
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(query): order by adhoc metrics should trigger group by ktmud/superset
2 participants
@ktmud @junlincc