Unknown Field error when editing dashboards with remote_id and import_time

[serenajiang]

When I try to edit the dashboard properties of a dashboard with the dashboard properties modal, if the dashboard has properties remote_id or import_time in the json metadata, I get the message An error occurred. The request error shows an Unknown Field error.

{"message":{"json_metadata":[{"import_time":["Unknown field."],"remote_id":["Unknown field."]}]}}

Expected results

The dashboard should save.

Actual results

Error.

Screenshots

How to reproduce the bug

1. Import a dashboard (or use existing imported dashboard)
2. Navigate to imported dashboard, open dashboard properties modal (edit dashboard properties)
3. Check the json metadata (Advanced) and confirm remote_id and import_time are properties
4. Save the dashboard properties.
5. Observe error.

Environment

(please complete the following information):

• superset version: Up to date with apache/master as of August 25, 2020
• python version: python --version 3.6

Checklist

Make sure these boxes are checked before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

cc: @graceguo-supercat

[issue-label-bot]

Issue-Label Bot is automatically applying the label #bug to this issue, with a confidence of 0.97. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[serenajiang]

@dpgaspar ?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[michellethomas]

Seeing this issue again. It looks like validation is happening on json_metadata when saving dashboard metadata. These fields are not in the valid schema so they are erroring.

@betodealmeida it looks like remote_id and import_time are related to import/export feature. I still see these fields used in the codebase, should they be added as a valid field in json_metadata? Or do you know who would know?