Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certification of Data Entities #10591

Closed
etr2460 opened this issue Aug 12, 2020 · 3 comments
Closed

Certification of Data Entities #10591

etr2460 opened this issue Aug 12, 2020 · 3 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention

Comments

@etr2460
Copy link
Member

etr2460 commented Aug 12, 2020

Is your feature request related to a problem? Please describe.
In larger deployments of Superset, it can be difficult to know which tables, datasources, and metrics are the correct ones to use. Many entities may have similar names, but no structured way exists to find the single source of truth.

Describe the solution you'd like
I propose the addition of a certified field on various data entities (tables and sql_metrics to start). Certification represents the review of a data entity by someone (a person, a group, a process) which adds an additional level of trust and verification to the entity.

This field will live JSON encoded in a new extra column added to the metadata database for these two tables. The structure of the data will be as follows:

{
  "certification": {
    "certified_by": "Erik Ritter",
    "details": "This metric is the single source of truth for births." 
  }
}

These certifications will be exposed in the UI anywhere a table or metric is referenced with the use of an icon before the table/metric name. In the future, we can also extend this approach to other data entities such as columns, slices, and dashboards.

Describe alternatives you've considered
I'm proposing a generic extra column as opposed to a more structured certifications table because I anticipate some iteration on this feature, and using a generic JSON string column allows for faster and safer iteration, as well as reduces the number of db migrations required. After all work concludes and the product is in a stable place, we can consider a migration to a more structured db representation.

Additional context
Tableau's implementation of certification

I'll be PR-ing out work around this feature in the next couple weeks, so here's the context behind the what/why of these PRs!

@etr2460 etr2460 added the enhancement:request Enhancement request submitted by anyone from the community label Aug 12, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.84. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Oct 22, 2020
@etr2460 etr2460 added the .pinned Draws attention label Oct 26, 2020
@stale stale bot removed the inactive Inactive for >= 30 days label Oct 26, 2020
@etr2460
Copy link
Member Author

etr2460 commented Apr 21, 2021

Closing this issue since a lot of the work is done already and it's tracked in the roadmap: apache-superset/superset-roadmap#73

@etr2460 etr2460 closed this as completed Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community .pinned Draws attention
Projects
None yet
Development

No branches or pull requests

1 participant