Edit the default "No Results" message

[larsmars]

Is your feature request related to a problem? Please describe.
When superset chart is used as iFrame make it posible to edit the default "No Results" message to you pref.

Default text today:
No Results
No results were returned for this query. If you expected results to be returned, ensure any filters are configured properly and the datasource contains data for the selected time range.

Describe the solution you'd like
Config parameter to edit default text and header for "No Results"

Additional context
Screenshot of as is today:

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[larsmars]

bump

[mistercrunch]

There's been some design work between Airbnb and Preset to redesign error messages from the ground up. I don't think that work is available in the open just yet, but there's a plan to make error messages much more clear and actionable.

[sarahbarberuk]

I'm also interested in this

[Neel-rishabhsoft]

I am as well interested. But, meanwhile they become open is there anything I can do alter this default message temporarily?
I have been stuck on changing this for weeks, any suggestion would be really helpful.
Thanks in advance.

[mistercrunch]

FYI this is where it lives: https://github.com/apache-superset/superset-ui/blob/master/packages/superset-ui-core/src/chart/components/NoResultsComponent.tsx#L8

[Neel-rishabhsoft]

Hi @mistercrunch, thanks for the reply.
I am sorry if I sound really daft. But I am not able to detect how this superset-ui plugins are connect with core "incubator-superset" code. I have searched the libraries getting installed with Superset & superset-ui doesnt get installed with it. So I am guessing there must be a connection point somewhere in the core code.
Can you please give me some direction in which I can move to alter the superset-ui code?

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[baltom]

I'm also interested in this. Would be a nice feature

[lucaxsilveira]

I'm also interested in this.

[junlincc]

@baltom @lucaxsilveira @Neel-rishabhsoft thanks for interested in contributing!

@villebro @ktmud could you give some pointers where/how folks from community can make this change? thanks!

[ktmud]

As Max noted, currently this text is hard-coded in a superset-ui component, which, like all superset-ui changes, is not every easy to update.

I'm hesitant to add another config value just for this message, but we can maybe either

1. Move SuperChart or the no-results file out of superset-ui to make it easier to override
2. Handle no results like regular frontend errors, so we can reuse the error message registry introduced by @etr2460 , or
3. Wait for monorepo migration ([SIP-58] Proposal to move superset-ui to this repo #13013)

[maltoze]

If this pr(apache-superset/superset-ui#1144) is merged, we can alter this message temporarily by updating the translation file.