From ef1d47c0dddba266c5bc6399a82bd1da101f5131 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=90=E1=BB=97=20Tr=E1=BB=8Dng=20H=E1=BA=A3i?= <41283691+hainenber@users.noreply.github.com> Date: Sat, 29 Jun 2024 02:45:38 +0700 Subject: [PATCH] chore(frontend): remove obsolete ESLint rules in tests (#29405) Signed-off-by: hainenber --- superset-frontend/src/SqlLab/actions/sqlLab.test.js | 1 - superset-frontend/src/explore/actions/exploreActions.test.js | 1 - .../src/explore/components/controls/CheckboxControl.test.tsx | 1 - .../FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx | 1 - .../AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx | 1 - .../AdhocFilterEditPopoverSimpleTabContent.test.tsx | 1 - .../AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx | 1 - .../components/controls/MetricControl/AdhocMetricOption.test.jsx | 1 - .../controls/MetricControl/FilterDefinitionOption.test.jsx | 1 - .../controls/MetricControl/MetricDefinitionValue.test.jsx | 1 - .../components/controls/MetricControl/MetricsControl.test.jsx | 1 - .../src/explore/components/controls/SelectControl.test.jsx | 1 - .../src/explore/components/controls/TextAreaControl.test.jsx | 1 - .../src/explore/components/controls/ViewportControl.test.jsx | 1 - 14 files changed, 14 deletions(-) diff --git a/superset-frontend/src/SqlLab/actions/sqlLab.test.js b/superset-frontend/src/SqlLab/actions/sqlLab.test.js index 11ab424512b0d..f889d81ffb714 100644 --- a/superset-frontend/src/SqlLab/actions/sqlLab.test.js +++ b/superset-frontend/src/SqlLab/actions/sqlLab.test.js @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint no-unused-expressions: 0 */ import sinon from 'sinon'; import fetchMock from 'fetch-mock'; import configureMockStore from 'redux-mock-store'; diff --git a/superset-frontend/src/explore/actions/exploreActions.test.js b/superset-frontend/src/explore/actions/exploreActions.test.js index 12bbdce4e7df9..77c204cf3fa1e 100644 --- a/superset-frontend/src/explore/actions/exploreActions.test.js +++ b/superset-frontend/src/explore/actions/exploreActions.test.js @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import { defaultState } from 'src/explore/store'; import exploreReducer from 'src/explore/reducers/exploreReducer'; import * as actions from 'src/explore/actions/exploreActions'; diff --git a/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx b/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx index 84ba568225246..9ad8f891e1cc6 100644 --- a/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx +++ b/superset-frontend/src/explore/components/controls/CheckboxControl.test.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import { render, screen } from 'spec/helpers/testing-library'; import { ThemeProvider, supersetTheme } from '@superset-ui/core'; import CheckboxControl from 'src/explore/components/controls/CheckboxControl'; diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx index ffd2d176018c8..55f2ea7018a24 100644 --- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx +++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl/AdhocFilterControl.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; import { supersetTheme } from '@superset-ui/core'; diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx index 594c20fd83be6..3a8e8d0745cef 100644 --- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx +++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopover/AdhocFilterEditPopover.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; import Button from 'src/components/Button'; diff --git a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx index 05f1ad0fc785c..1e352cc38d3a0 100644 --- a/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx +++ b/superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/AdhocFilterEditPopoverSimpleTabContent.test.tsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import * as redux from 'react-redux'; import sinon from 'sinon'; import { shallow } from 'enzyme'; diff --git a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx index e51c14f2a6f9b..06b8b8a9eeb98 100644 --- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx +++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/AdhocMetricEditPopover.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; import { FormItem } from 'src/components/Form'; diff --git a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx index bf1b501ac1726..1ef070de81195 100644 --- a/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx +++ b/superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricOption.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; diff --git a/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx index fb920cb7c630f..a1bbc1cb14db4 100644 --- a/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx +++ b/superset-frontend/src/explore/components/controls/MetricControl/FilterDefinitionOption.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import { render, screen } from 'spec/helpers/testing-library'; import FilterDefinitionOption from 'src/explore/components/controls/MetricControl/FilterDefinitionOption'; import { AGGREGATES } from 'src/explore/constants'; diff --git a/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx index 259220bb4bc00..3b51fcc5083ae 100644 --- a/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx +++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import { shallow } from 'enzyme'; import { AGGREGATES } from 'src/explore/constants'; diff --git a/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx b/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx index 1be8b2aa97c3f..bfc7349107a2c 100644 --- a/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx +++ b/superset-frontend/src/explore/components/controls/MetricControl/MetricsControl.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; diff --git a/superset-frontend/src/explore/components/controls/SelectControl.test.jsx b/superset-frontend/src/explore/components/controls/SelectControl.test.jsx index 4b38ef72b1b49..d86c334be17b5 100644 --- a/superset-frontend/src/explore/components/controls/SelectControl.test.jsx +++ b/superset-frontend/src/explore/components/controls/SelectControl.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { shallow } from 'enzyme'; import { Select as SelectComponent } from 'src/components'; diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx index e77a693102113..402c69934d71f 100644 --- a/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx +++ b/superset-frontend/src/explore/components/controls/TextAreaControl.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import sinon from 'sinon'; import { styledMount as mount } from 'spec/helpers/theming'; import { TextAreaEditor } from 'src/components/AsyncAceEditor'; diff --git a/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx b/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx index d74612a6108cc..282e39f6b1ec1 100644 --- a/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx +++ b/superset-frontend/src/explore/components/controls/ViewportControl.test.jsx @@ -16,7 +16,6 @@ * specific language governing permissions and limitations * under the License. */ -/* eslint-disable no-unused-expressions */ import { styledMount as mount } from 'spec/helpers/theming'; import Popover from 'src/components/Popover';