From b92f12348d3719db6506950124479564529b9087 Mon Sep 17 00:00:00 2001 From: "Michael S. molina" Date: Tue, 28 Mar 2023 13:44:19 -0300 Subject: [PATCH] Uses useRef for lastSpecificScope --- .../FiltersConfigForm/FilterScope/FilterScope.tsx | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx index 35fb2373fad41..0682279120d0b 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FilterScope/FilterScope.tsx @@ -17,7 +17,7 @@ * under the License. */ -import React, { FC, useCallback, useState } from 'react'; +import React, { FC, useCallback, useRef, useState } from 'react'; import { NativeFilterScope, styled, @@ -67,8 +67,7 @@ const FilterScope: FC = ({ const [initialFilterScope] = useState( filterScope || getDefaultScopeValue(chartId, initiallyExcludedCharts), ); - const [lastSpecificScope, setLastSpecificScope] = - useState(initialFilterScope); + const lastSpecificScope = useRef(initialFilterScope); const [initialScopingType] = useState( isScopingAll(initialFilterScope, chartId) ? ScopingType.all @@ -81,7 +80,7 @@ const FilterScope: FC = ({ const onUpdateFormValues = useCallback( (formValues: any) => { if (formScopingType === ScopingType.specific) { - setLastSpecificScope(formValues.scope); + lastSpecificScope.current = formValues.scope; } updateFormValues(formValues); setHasScopeBeenModified(true); @@ -121,7 +120,7 @@ const FilterScope: FC = ({ const scope = value === ScopingType.all ? getDefaultScopeValue(chartId) - : lastSpecificScope; + : lastSpecificScope.current; updateFormValues({ scope }); setHasScopeBeenModified(true); forceUpdate();