From 60f04f182a920bdd1ff58edfb506c754d623aab6 Mon Sep 17 00:00:00 2001 From: PApostol <50751110+PApostol@users.noreply.github.com> Date: Tue, 9 Nov 2021 15:44:10 +0000 Subject: [PATCH] fix: various typo fixes in MD files (#17309) * Various typo fixes in MD files * Undo fixes in CHANGELOG.md to match PR titles * Update CONTRIBUTING.md Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> --- CONTRIBUTING.md | 6 +++--- RELEASING/README.md | 2 +- UPDATING.md | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ffe592bf04639..898024c382701 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -904,7 +904,7 @@ apt install -y net-tools pip install debugpy ``` -Find the PID for the Flask process. Make sure to use the first PID. The Flask app will re-spawn a sub-process everytime you change any of the python code. So it's important to use the first PID. +Find the PID for the Flask process. Make sure to use the first PID. The Flask app will re-spawn a sub-process every time you change any of the python code. So it's important to use the first PID. ```bash ps -ef @@ -975,7 +975,7 @@ Once the pod is running as root and has the SYS_PTRACE capability it will be abl You can follow the same instructions as in the docker-compose. Enter the pod and install the required library and packages; gdb, netstat and debugpy. -Often in a kuernetes environment nodes are not addressable from ouside the cluster. VSCode will thus be unable to remotely connect to port 5678 on a kubernetes node. In order to do this you need to create a tunnel that port forwards 5678 to your local machine. +Often in a Kubernetes environment nodes are not addressable from outside the cluster. VSCode will thus be unable to remotely connect to port 5678 on a Kubernetes node. In order to do this you need to create a tunnel that port forwards 5678 to your local machine. ``` kubectl port-forward pod/superset- 5678:5678 @@ -1341,7 +1341,7 @@ Chart parameters are stored as a JSON encoded string the `slices.params` column The following tables provide a non-exhausive list of the various fields which can be present in the JSON object grouped by the Explorer pane sections. These values were obtained by extracting the distinct fields from a legacy deployment consisting of tens of thousands of charts and thus some fields may be missing whilst others may be deprecated. -Note not all fields are correctly catagorized. The fields vary based on visualization type and may apprear in different sections depending on the type. Verified deprecated columns may indicate a missing migration and/or prior migrations which were unsucessful and thus future work may be required to clean up the form-data. +Note not all fields are correctly categorized. The fields vary based on visualization type and may apprear in different sections depending on the type. Verified deprecated columns may indicate a missing migration and/or prior migrations which were unsuccessful and thus future work may be required to clean up the form-data. ### Datasource & Chart Type diff --git a/RELEASING/README.md b/RELEASING/README.md index 92934a49ea836..2ab5b3204a2af 100644 --- a/RELEASING/README.md +++ b/RELEASING/README.md @@ -179,7 +179,7 @@ the tag and create a signed source tarball from it: Note that `make_tarball.sh`: - By default assumes you have already executed an SVN checkout to `$HOME/svn/superset_dev`. -This can be overriden by setting `SUPERSET_SVN_DEV_PATH` environment var to a different svn dev directory +This can be overridden by setting `SUPERSET_SVN_DEV_PATH` environment var to a different svn dev directory - Will refuse to craft a new release candidate if a release already exists on your local svn dev directory - Will check `package.json` version number and fails if it's not correctly set diff --git a/UPDATING.md b/UPDATING.md index 6cb3c83ebf7e5..d844ef4ed01a7 100644 --- a/UPDATING.md +++ b/UPDATING.md @@ -49,7 +49,7 @@ assists people when migrating to a new version. ### Potential Downtime -- [14234](https://github.com/apache/superset/pull/14234): Adds the `limiting_factor` column to the `query` table. Give the migration includes a DDL operation on a heavily trafficed table, potential service downtime may be required. +- [14234](https://github.com/apache/superset/pull/14234): Adds the `limiting_factor` column to the `query` table. Give the migration includes a DDL operation on a heavily trafficked table, potential service downtime may be required. -[16454](https://github.com/apache/superset/pull/16454): Adds the `extra` column to the `table_columns` table. Users using MySQL will either need to schedule downtime or use the percona toolkit (or similar) to perform the migration. @@ -232,7 +232,7 @@ assists people when migrating to a new version. - [8699](https://github.com/apache/superset/pull/8699): A `row_level_security_filters` table has been added, which is many-to-many with `tables` and `ab_roles`. The applicable filters are added to the sqla query, and the RLS ids are added to the query cache keys. If RLS is enabled in config.py (`ENABLE_ROW_LEVEL_SECURITY = True`; by default, it is disabled), they can be - accessed through the `Security` menu, or when editting a table. + accessed through the `Security` menu, or when editing a table. - [8732](https://github.com/apache/superset/pull/8732): Swagger user interface is now enabled by default. A new permission `show on SwaggerView` is created by `superset init` and given to the `Admin` Role. To disable the UI, @@ -411,7 +411,7 @@ Superset 0.25.0 contains a backwards incompatible changes. If you run a production system you should schedule downtime for this upgrade. -The PRs bellow have more information around the breaking changes: +The PRs below have more information around the breaking changes: - [9825](https://github.com/apache/superset/pull/9825): Support for Excel sheet upload added. To enable support, install Superset with the optional dependency `excel`