From 521f8670f068aba38194b672b3ef4f042b1e0e30 Mon Sep 17 00:00:00 2001 From: Krist Wongsuphasawat Date: Fri, 29 Mar 2019 16:41:46 -0700 Subject: [PATCH] chore: add eslint react fragment rule (#32) * chore: add eslint react fragment rule * fix: lint * fix: react16 --- .../superset-ui/plugins/superset-ui-plugins/package.json | 2 +- .../packages/superset-ui-preset-chart-xy/package.json | 2 +- .../superset-ui-preset-chart-xy/src/Line/createTooltip.tsx | 4 ++-- .../src/components/ChartLegend.tsx | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json index d77b411f6fba0..fe4555706146e 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/package.json @@ -38,7 +38,7 @@ ], "license": "Apache-2.0", "devDependencies": { - "@superset-ui/build-config": "^0.0.4", + "@superset-ui/build-config": "^0.0.6", "@superset-ui/chart": "^0.10.8", "@superset-ui/color": "^0.10.0", "@superset-ui/connection": "^0.10.0", diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json index f6b9704223c6f..0abed41b5c6fa 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/package.json @@ -53,6 +53,6 @@ "@superset-ui/number-format": "^0.10.0", "@superset-ui/time-format": "^0.10.0", "@superset-ui/translation": "^0.10.0", - "react": "^15 || ^16" + "react": "^16.2" } } diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx index cf4c01d9ed508..86f077f0d83e8 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/Line/createTooltip.tsx @@ -20,7 +20,7 @@ export default function createTooltip(encoder: Encoder, allSeries: Series[]) { }) { return ( - + <>
{encoder.channels.x.formatValue(datum.x)}
@@ -41,7 +41,7 @@ export default function createTooltip(encoder: Encoder, allSeries: Series[]) { }))} /> )} -
+
); } diff --git a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx index 78b4277f92ede..0658a76850e1c 100644 --- a/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx +++ b/superset-frontend/temporary_superset_ui/superset-ui/plugins/superset-ui-plugins/packages/superset-ui-preset-chart-xy/src/components/ChartLegend.tsx @@ -86,6 +86,6 @@ export default class ChartLegend< ); }); - return {legends}; + return <>{legends}; } }