From 28b494c59724eb9b48e387c8a48c7a1b5cd741ca Mon Sep 17 00:00:00 2001 From: Daman Arora <61474540+Damans227@users.noreply.github.com> Date: Tue, 2 Nov 2021 14:51:16 -0400 Subject: [PATCH] chore: migrate HiddenControl component from jsx to tsx (#17315) * migrate HiddenControl component from jsx to tsx * Update superset-frontend/src/explore/components/controls/HiddenControl.tsx Co-authored-by: Erik Ritter * updating the type of value in the interface * Update superset-frontend/src/explore/components/controls/HiddenControl.tsx Co-authored-by: Erik Ritter Co-authored-by: Erik Ritter --- .../{HiddenControl.jsx => HiddenControl.tsx} | 25 ++++--------------- 1 file changed, 5 insertions(+), 20 deletions(-) rename superset-frontend/src/explore/components/controls/{HiddenControl.jsx => HiddenControl.tsx} (69%) diff --git a/superset-frontend/src/explore/components/controls/HiddenControl.jsx b/superset-frontend/src/explore/components/controls/HiddenControl.tsx similarity index 69% rename from superset-frontend/src/explore/components/controls/HiddenControl.jsx rename to superset-frontend/src/explore/components/controls/HiddenControl.tsx index bc656af8564df..867f0fe2a0736 100644 --- a/superset-frontend/src/explore/components/controls/HiddenControl.jsx +++ b/superset-frontend/src/explore/components/controls/HiddenControl.tsx @@ -17,29 +17,14 @@ * under the License. */ import React from 'react'; -import PropTypes from 'prop-types'; import { Input } from 'src/common/components'; -const propTypes = { - onChange: PropTypes.func, - value: PropTypes.oneOfType([ - PropTypes.string, - PropTypes.number, - PropTypes.object, - PropTypes.bool, - PropTypes.array, - PropTypes.func, - ]), -}; - -const defaultProps = { - onChange: () => {}, -}; +interface HiddenControlsProps { + onChange: () => void; + value: string | number | readonly string[] | undefined; +} -export default function HiddenControl(props) { +export default function HiddenControl(props: HiddenControlsProps) { // This wouldn't be necessary but might as well return ; } - -HiddenControl.propTypes = propTypes; -HiddenControl.defaultProps = defaultProps;