Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support module definition change in BanyanDB storage. #12685

Closed
2 of 3 tasks
wu-sheng opened this issue Oct 9, 2024 · 2 comments · Fixed by #12808
Closed
2 of 3 tasks

[Feature] Support module definition change in BanyanDB storage. #12685

wu-sheng opened this issue Oct 9, 2024 · 2 comments · Fixed by #12808
Assignees
Labels
backend OAP backend related. database BanyanDB - SkyWalking native database feature New feature
Milestone

Comments

@wu-sheng
Copy link
Member

wu-sheng commented Oct 9, 2024

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Currently, we don't do column validation(name, type, existing) during booting, and would not upgrade the column update when the latest and existing are compatible.

We should consider adding this. Elasticsearch storage implementation would be a good reference.

Use case

No response

Related issues

No response

Are you willing to submit a pull request to implement this on your own?

  • Yes I am willing to submit a pull request on my own!

Code of Conduct

@wu-sheng wu-sheng added backend OAP backend related. feature New feature database BanyanDB - SkyWalking native database labels Oct 9, 2024
@wu-sheng wu-sheng added this to the 10.2.0 milestone Oct 9, 2024
@wu-sheng
Copy link
Member Author

@wankai123 Considering #12442, let's add a database version number concept in OAP codebase. Once we have this in place, we have a chance to do incompatible upgrade through two group.

e.g. banyandb_db_schema_v = 1, and we need some incompatible upgrade, introduced a new kind of index, but the query logic is consistent. We could do banyandb_db_schema_v=2(compatible with banyandb_db_schema_v=1).

Then, when we apply definition change through create new schema_v suffix groups.

@wu-sheng
Copy link
Member Author

@wankai123 Considering #12442, let's add a database version number concept in OAP codebase. Once we have this in place, we have a chance to do incompatible upgrade through two group.

e.g. banyandb_db_schema_v = 1, and we need some incompatible upgrade, introduced a new kind of index, but the query logic is consistent. We could do banyandb_db_schema_v=2(compatible with banyandb_db_schema_v=1).

Then, when we apply definition change through create new schema_v suffix groups.

@wankai123 #12442 has been moved to 0.9, so OAP will consider that for 10.3 only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend OAP backend related. database BanyanDB - SkyWalking native database feature New feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants