Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

which is the last release version that can be compiled with jdk8? #31379

Closed
darren-wang opened this issue May 24, 2024 · 4 comments
Closed

which is the last release version that can be compiled with jdk8? #31379

darren-wang opened this issue May 24, 2024 · 4 comments

Comments

@darren-wang
Copy link

I read https://shardingsphere.apache.org/community/cn/involved/contribute/dev-env/ to know that JDK11+ is needed to set up dev environment, the PR #23550 also said that JDK11+ is forced.

However, there is only jdk8 in my organization and when I cloned the source code, I found jdk8 profile in IDEA's maven view.

So here comes my questions:

  1. What is the meaning of 'jdk8' profile in the source code, does it mean that I can still compile the source code with jdk8 using this profile?
  2. If I can NOT compile the latest release with jdk8, which is the last release whose source code can be compiled with jdk8?
  3. Could the latest release 5.5.0 be used with jre8, NOT compiling its source but only to use it with spring boot and jre8?
@zhaojinchao95
Copy link
Contributor

  1. Can't compile using jdk8
  2. 5.3.1
  3. ShardingSphere can be used in the jdk8 environment

@darren-wang
Copy link
Author

  1. Can't compile using jdk8
  2. 5.3.1
  3. ShardingSphere can be used in the jdk8 environment

@zhaojinchao95 Great thanks !!! And if we can NOT compile shardingsphere 5.5.0 on jdk1.8 even with profile jdk8 , then what is the usage of maven profile jdk8 in source code? Are there any docs on it?

@terrymanu
Copy link
Member

Please see https://github.com/apache/shardingsphere/blob/abaf4067f3f1df4e8e7c36fad0816c257a923287/.github/workflows/ci.yml and search content CI - Compile by JDK 11 and Run on JDK 8 to find the hint.

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants