Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] A more flexible way of credential configuration #9133

Open
1 task done
zeyu-zh opened this issue Jan 15, 2025 · 0 comments · May be fixed by #9134
Open
1 task done

[Enhancement] A more flexible way of credential configuration #9133

zeyu-zh opened this issue Jan 15, 2025 · 0 comments · May be fixed by #9134

Comments

@zeyu-zh
Copy link

zeyu-zh commented Jan 15, 2025

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

Looking for a way to customize the way credentials are provided.

Motivation

To make it more flexible and secure.

Describe the Solution You'd Like

Here we propose to import a new interface SessionCredentialsProvider which has a method getCredentials. This is a common handling approach in other SDKs.

Describe Alternatives You've Considered

Currently the AclClientRPCHook takes SessionCredentials as input, and then invoke method getAccessKey, getSecretKey and getSecurityToken to get the different fields.

Extending SessionCredentials is not feasible as the credentials may need be refreshed and it could happen at any time, e.g.

  • getAccessKey()
  • refreshCredentials()
  • getSecretKey()
  • getSecurityToken()

then the accessKeyId is not match with secretKey and securityToken.

Additional Context

No response

zeyu-zh added a commit to zeyu-zh/rocketmq that referenced this issue Jan 15, 2025
@zeyu-zh zeyu-zh linked a pull request Jan 15, 2025 that will close this issue
zeyu-zh added a commit to zeyu-zh/rocketmq that referenced this issue Jan 17, 2025
zeyu-zh added a commit to zeyu-zh/rocketmq that referenced this issue Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant