Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why was an obviously wrong commit merged? #1156

Open
bilinxing opened this issue Aug 12, 2024 · 1 comment · May be fixed by #1172
Open

Why was an obviously wrong commit merged? #1156

bilinxing opened this issue Aug 12, 2024 · 1 comment · May be fixed by #1172
Labels
doc Document, comments and clean code good first issue Good for newcomers

Comments

@bilinxing
Copy link

f7960e7
@francisoliverlee francisoliverlee added good first issue Good for newcomers doc Document, comments and clean code labels Sep 14, 2024
@francisoliverlee
Copy link
Member

that's very nice of you -_-, can you submit a NEW PR to fix it

@yuz10 yuz10 linked a pull request Oct 8, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
doc Document, comments and clean code good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ISSUE #1156] change "UnkonwnState" to "UnknownState" yuz10/rocketmq-client-go
2 participants
@francisoliverlee @bilinxing