-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should introduce deleting state for ledger deletion #13238
Labels
help wanted
lifecycle/stale
Stale
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Milestone
Comments
I can help with this issue~ |
@wuzhanpeng Thanks for your help, I have assigned this issue to you. If you have any questions or need any help, please ping me at any time. You'd better write a proposal first. |
The issue had no activity for 30 days, mark with Stale label. |
The issue had no activity for 30 days, mark with Stale label. |
3 tasks
4 tasks
Superseded by #16569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
help wanted
lifecycle/stale
Stale
type/enhancement
The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Is your enhancement request related to a problem? Please describe.
In current ledger deletion, we divided it into two separate steps.
Due to the separate step, we can't ensure the ledger deletion transaction. If the first step succeed and the second step failed, it will lead to ledgers can't be deleted from storage system forever. The second step maybe fail by broker restart or storage system deletion failed.
pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
Lines 2532 to 2561 in bd68b6f
In our customer's environment, we have found many orphan ledgers cause by the above reason.
Describe the solution you'd like
We'd better introduce a
deleting
state for the waiting to delete ledgers. The desired ledger deletion should follow the three steps.deleting
state.deleting
state ledgers, and do ledger delete operation on storage system. Each topic's owner control their own topics' ledger deletion.The text was updated successfully, but these errors were encountered: