Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix snapshot check #295

Merged
merged 1 commit into from
Aug 7, 2023
Merged

fix snapshot check #295

merged 1 commit into from
Aug 7, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Aug 7, 2023

problems with #294

  • I added a stray " into the regex
  • the Group match has to handle 3 extra subgroups that the regex change brings in
    • for 1.1.0-M0+22-4f570ea2-SNAPSHOT, the 3 extra subgroups are -M0, -M, 0
    • if there is no -M0 (or -RC0), the extra subgroups are all null
  • the sorting will do for now but it doesn't take into account whether the tag is M or RC and there are other problems
  • I did play around with sbt.librarymanagement.VersionNumber but it doesn't have a comparator (or scala.Ordering implementation).
    • I will try this again to see if I can create my own comparator for sbt.librarymanagement.VersionNumber
    • using this PR to get the build working for now
  • I have tested these changes on my laptop

Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mdedetrich
Copy link
Contributor

mdedetrich commented Aug 7, 2023

I will try this again to see if I can create my own comparator for sbt.librarymanagement.VersionNumber

Having an ordering number for a VersionNumber doesn't make sense in a library like sbt because its completely bespoke, different orgs have the option of making their own release strategies.

In any case I would recommend how we talk about this problem in general rather than spending time perfecting the current solution because there are issues in just using the latest snapshot as is done now, i.e. the builds are not deterministic which can be especially problematic if you are checking out past versions of pekko-http (i.e. trying to disect/figure out a bug) and instead of resolving the pekko version at that time you are instead resolving a completely different modern version.

@pjfanning pjfanning merged commit e7da6d3 into apache:main Aug 7, 2023
@pjfanning pjfanning deleted the snapshot-check branch August 7, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants