Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to fix issues in source tgz with the linked-dir #444

Closed
pjfanning opened this issue Jan 26, 2024 · 1 comment
Closed

need to fix issues in source tgz with the linked-dir #444

pjfanning opened this issue Jan 26, 2024 · 1 comment

Comments

@pjfanning
Copy link
Contributor

pjfanning commented Jan 26, 2024

We had issues in the last pekko-http release with the linked dir used in testing. Seemed to only affect Windows users then but now, it's affecting Mac users.

x apache-pekko-http-1.0.1-RC1-incubating-src-20240126/http-tests/src/test/resources/dirWithLink/linked-dir: Truncated tar archive
tar: Error exit delayed from previous errors.

same dir that causes the issue in #275

@pjfanning
Copy link
Contributor Author

I looked at sbt-source-dist and it might be possible to get it some symlinks - but I think we are better off rewriting the FileAndResourceDirectivesSpec so that it creates a temp dir that has all the files and symlinks set up by the test code before we run the main part of the test - i.e. remove the need for the symlink being checked into git and being reproduced in the tgz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant