support scala 2.13 and scala 3 build for codegen lib #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pjfanning
commented
Sep 22, 2023
•
pjfanning
commented
- upgrades twirl plugin so that we can support scala 3
- CodeGenerator needs to be different in Scala 2.12 (needs a nowarn but this causes newer Scala versions to not allow compilation)
- relates to Publish the pekko-grpc-codegen package for Scala 2.13 #180
He-Pin
approved these changes
Sep 23, 2023
| /** Takes Scala binary version and returns suggested dependency Seq */ | ||
| def suggestedDependencies: ScalaBinaryVersion => Seq[Artifact] | ||
|
|
||
| def registerExtensions(registry: ExtensionRegistry): Unit = {} |
There was a problem hiding this comment.
the original code (still in use for scala 2.12 compile) does not have scaladoc so I don't want to make the 2 versions differ from each other
There was a problem hiding this comment.
okay, but you can add doc in both place :)
There was a problem hiding this comment.
I'm not a fan of hijacking PRs to make unrelated changes - if you want new scaladoc, create a new Issue or PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.