Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate a historical issue: gzip shouldn't be included by default ? #286

Open
laglangyue opened this issue Apr 9, 2024 · 7 comments

Comments

@laglangyue
Copy link
Contributor

laglangyue commented Apr 9, 2024

I have been interested in FIXME of GRPC.
image

image

So I want to talk about :
(1)Gzip should be the default, or only use Identity?
(2)supportedCodecs can be configured by reference?

In my opinion, according to the comments, gzip is not the default value for the client. Users can modify the supported codecs through the conf file

@laglangyue
Copy link
Contributor Author

@raboof I saw your comments from the PR of history in akka-grpc,WDYT ?

@Roiocam
Copy link
Member

Roiocam commented Apr 9, 2024

Seems like it is the same issue grpc/grpc-java#8542?

@laglangyue
Copy link
Contributor Author

Seems like it is the same issue grpc/grpc-java#8542?

thanks, let me see

@mdedetrich
Copy link
Contributor

Seems like it is the same issue grpc/grpc-java#8542?

If I am reading this correctly this appears to be a non issue creating by a misunderstanding, i.e. Message-Accept-Encoding should list all of the compression schemes that you support, not the ones that is being used right now.

@raboof
Copy link
Member

raboof commented Apr 10, 2024

I think the limitation identified here was the fact that we currently do not provide a way for the client to prevent the server from compressing the responses. This could be interesting to allow when making requests from low-powered machines, where you might be happy to spend a bit more bandwidth if it means spending less CPU time decompressing.

No idea why it was added as a 'FIXME' rather than a regular feature request, though - in retrospect it seems rather niche.

@pjfanning
Copy link
Contributor

I agree that this is not a major issue. If someone wants to add a config setting that allows users to disable compression support then that is nice to have

@laglangyue
Copy link
Contributor Author

Thanks for all. I only started reading the PR related to grpc-Java.

Yes, aggre that it is a Feature, not FXIME.
GRPC-Java already support APIs for registering compression methods
grpc/grpc-java#1704
grpc/grpc-java#9942

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants