PARQUET-371: update thrift dependency to 0.9.3; do not shade slf4j #50
Conversation
julienledem
changed the title
|
@rdblue I think we should get this in. It is a pain to be on thrift 0.7 |
|
I'm for it, but we need to make sure there is no compatibility issue. Have you run any tests to make sure that older versions can read files written using 0.9.3? Or is there no compatibility concern? (I'm not sure what binary guarnatees thrift makes) |
|
I think that thrift guarantees wire compatibility but I haven't tested it. |
|
Is that documented anywhere? I remember I couldn't actually find the thrift binary format other than as a text file attached to a JIRA somewhere... and I've since lost even that. |
|
+1 I built parquet-cli using a 2.3.2-SNAPSHOT including this patch. I checked that it could read as expected and that a file written by it was still compatible with the older version. |
closes apache#43 and closes apache#50 This PR also implements 1) PARQUET-532: Null values detection needs to be fixed and tested 2) PARQUET-502: Scanner segfaults when its batch size is smaller than the number of rows 3) PARQUET-526: Add more complete unit test coverage for column Scanner implementations 4) PARQUET-531: Can't read past first page in a column Author: Deepak Majeti <[email protected]> Closes apache#62 from majetideepak/PARQUET-538 and squashes the following commits: 1e56f83 [Deepak Majeti] Trigger notification 6478a7c [Deepak Majeti] TYPED_TEST 1d14171 [Deepak Majeti] Added Boolean Test and Scanner:Next API d1da031 [Deepak Majeti] lint issue 45f10aa [Deepak Majeti] Reproducer for PARQUET-502 88e27c6 [Deepak Majeti] formatting 8aac435 [Deepak Majeti] PARQUET-526 dca7e2d [Deepak Majeti] PARQUET-532 and PARQUET-502 Fix a622021 [Deepak Majeti] Reverted PARQUET-524 and addressed comments 859c1df [Deepak Majeti] minor comment edits d938a13 [Deepak Majeti] PARQUET-538 df1fbd7 [Deepak Majeti] Templated single page tests 8548e3c [Deepak Majeti] PARQUET-524 c265fea [Deepak Majeti] fixed PARQUET-499 bugs
No description provided.