Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build non-source test artifacts from source #1073

Open
dgrove-oss opened this issue Sep 17, 2019 · 1 comment
Open

Build non-source test artifacts from source #1073

dgrove-oss opened this issue Sep 17, 2019 · 1 comment

Comments

@dgrove-oss
Copy link
Member

The directory tests/src/integration contains a number of non-source artifacts (.zip, .jar, compiled executables) that cannot be included in an Apache source release.

A build target should be added to re-create all these files from source (and the artifacts should either be removed from git entirely or centralized to a single directory like tests/dat/ or tests/binary that can be cleanly excluded from source releases).

The current list is:

scanning for unexpected file types... failed
/openwhisk-wskdeploy-1.0.0/tests/src/integration/helloworld/actions/hello.zip:
 application/zip; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/helloworld/actions/hello.jar:
 application/java-archive; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/docker/actions/go/exec:
 application/x-executable; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/docker/actions/exec.zip:
 application/zip; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/validate-packages-in-manifest/actions/hello.jar:
 application/java-archive; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/jaraction/src/hello.jar:
 application/java-archive; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/runtimetests/src/helloworld/helloworld.zip:
 application/zip; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/runtimetests/src/helloDotNet.src.zip:
 application/zip; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/runtimetests/src/hello.jar:
 application/java-archive; charset=binary
/openwhisk-wskdeploy-1.0.0/tests/src/integration/runtimetests/src/helloDotNet.zip:
 application/zip; charset=binary)
scanning for archives ... failed
(/openwhisk-wskdeploy-1.0.0/tests/src/integration/helloworld/actions/hello.jar
/openwhisk-wskdeploy-1.0.0/tests/src/integration/validate-packages-in-manifest/actions/hello.jar
/openwhisk-wskdeploy-1.0.0/tests/src/integration/jaraction/src/hello.jar
/openwhisk-wskdeploy-1.0.0/tests/src/integration/runtimetests/src/hello.jar)
@dgrove-oss
Copy link
Member Author

dgrove-oss commented Sep 17, 2019

Note, when this issue is fixed, the exclusion in the release script package_source_code.sh addded in apache/openwhisk-release#301 should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant