Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore missing documentation about how to test runtimes standalone. #227

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Restore missing documentation about how to test runtimes standalone. #227

wants to merge 6 commits into from

Conversation

Rurouni-Jiaxin
Copy link

@Rurouni-Jiaxin Rurouni-Jiaxin commented Oct 31, 2022 •
edited
Loading

In this repo, the instructions on building and running the standalone runtime container is missing. Therefore this PR is created to fix that. @mrutkows review-requested:mrutkows

@Rurouni-Jiaxin Rurouni-Jiaxin marked this pull request as draft October 31, 2022 13:34
@Rurouni-Jiaxin Rurouni-Jiaxin marked this pull request as ready for review October 31, 2022 13:35
@mrutkows
Copy link
Contributor

mrutkows commented Nov 11, 2022 •
edited
Loading

@Rurouni-Jiaxin Would it be possible to

  1. update the top-level README.md to link to this "standalone" README?
    Perhaps under the https://github.com/apache/openwhisk-runtime-nodejs#testing section.

  2. Also, you may want to relocate your markdown to the "docs/user" dir. (e.g., https://github.com/apache/openwhisk-runtime-nodejs/blob/master/docs/users/)

  3. If you would kindly work in the 3 use cases (and link to their json data files) from here: https://github.com/apache/openwhisk-runtime-nodejs/tree/master/tests/src/test/knative that would be great!

@mrutkows
Copy link
Contributor

@Rurouni-Jiaxin you may want to look at this closed PR from a while ago which would have added pre-reqs and other info, that may be helpful (applied) to your new doc.
https://github.com/apache/openwhisk-runtime-nodejs/pull/190/files

@mrutkows mrutkows mentioned this pull request Nov 14, 2022
Merged
dgrove-oss
dgrove-oss reviewed Jan 30, 2023
View reviewed changes
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
docs/users/standalone/README.md Outdated Show resolved Hide resolved
@Rurouni-Jiaxin Rurouni-Jiaxin force-pushed the jfan/document/test branch 2 times, most recently from 7f37442 to 03a8541 Compare January 30, 2023 19:13
Jiaxin Fan added 3 commits January 30, 2023 20:33
Restore missing documentation about how to test runtimes standalone.
a2c0950 
Revised README, also add EOL at end of file

Attempt to fix trailing white space

Checked for typos

Fix minor formatting error, test Git still works

WIP: update top-level README
Relocate to doc/user dir
833375c
Explain Gradle and add one use case
5a2ae20
mrutkows
mrutkows requested changes Feb 2, 2023
View reviewed changes
tests/src/test/standalone/README.md Outdated Show resolved Hide resolved
tests/src/test/standalone/README.md Outdated Show resolved Hide resolved
tests/src/test/standalone/README.md Outdated Show resolved Hide resolved
docs/users/standalone/README.md Outdated Show resolved Hide resolved
Add example json files
c3c8503 
Add CI status

Rebase resolved

Squash commits

Update top level README

Rollback changes to ci.yaml
Jiaxin Fan added 2 commits February 6, 2023 14:06
Fix EOL scan
2e40767 
add EOL

Fix filepath in curl command
Replace filepath in curl
4ed273b
@mrutkows
Copy link
Contributor

mrutkows commented Feb 6, 2023 via email •
edited
Loading

@Rurouni-Jiaxin Rurouni-Jiaxin mentioned this pull request Jul 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss left review comments

@mrutkows mrutkows Awaiting requested review from mrutkows

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rurouni-Jiaxin @mrutkows @dgrove-oss