Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prep for 1.15 release #101

Merged
merged 1 commit into from
May 16, 2023
Merged

prep for 1.15 release #101

merged 1 commit into from
May 16, 2023

Conversation

dgrove-oss
Copy link
Member

No description provided.

@dgrove-oss dgrove-oss requested a review from Luke-Roy-IBM May 5, 2023 22:03
@dgrove-oss dgrove-oss requested a review from style95 May 15, 2023 18:10
Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor question.

@@ -22,6 +22,7 @@
## 1.15.0
- Update base python image to `python:3.11-alpine`
- Update python dependacies
- Support array result include sequence action (#92)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to add a link to the PR explicitly just like this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the PR is to the same repository as the release, then GitHub automatically converts the short form (#92) to the appropriate link when it is in the description of the release. We only need the longer form when we want to link to a PR in a different repository. Thanks for thinking of this though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgrove-oss dgrove-oss merged commit 1d8a6ed into apache:master May 16, 2023
@dgrove-oss dgrove-oss deleted the release-prep branch May 16, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants