Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindings/java: Enable retry layer by default in behavior test #3458

Closed
Xuanwo opened this issue Nov 1, 2023 · 5 comments · Fixed by #3392
Closed

bindings/java: Enable retry layer by default in behavior test #3458

Xuanwo opened this issue Nov 1, 2023 · 5 comments · Fixed by #3392

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Nov 1, 2023

No description provided.

@suyanhanx
Copy link
Member

suyanhanx commented Nov 2, 2023

Since this issue has not been resolved, the Dropbox service in java binding has been failing to test tentatively.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 2, 2023

Related to #3392

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 2, 2023

By the way, maybe we should also take a review on dropbox code to avoid such ratelimit. For example, check dir first before calling create_dir.

RateLimited (temporary) at create_dir => DropboxErrorResponse { error_summary: "too_many_write_operations/" }

Context:
   uri: https://api.dropboxapi.com/2/files/create_folder_v2
   response: Parts { status: 429, version: HTTP/2.0, headers: {"cache-control": "no-cache", "content-security-policy": "sandbox allow-forms allow-scripts", "retry-after": "1", "x-content-type-options": "nosniff", "content-type": "application/json", "accept-encoding": "identity,gzip", "date": "Thu, 02 Nov 2023 04:37:05 GMT", "server": "envoy", "content-length": "107", "x-dropbox-response-origin": "far_remote", "x-dropbox-request-id": "ba43ab1d9e994630942eb59d2c91ae4c"} }
   service: dropbox
   path: a7aa844b-7688-4a1a-8fc8-a03110d09eeb/

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 2, 2023

#3392 has been merged, let's add retry layer.

@Xuanwo Xuanwo reopened this Nov 2, 2023
@tisonkun
Copy link
Member

tisonkun commented Nov 2, 2023

It's already enabled with:

            this.operator = op.layer(RetryLayer.builder().build());

in the patch.

@tisonkun tisonkun closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants