[NIFI-12903] style updates for drag/drop UX #8729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottyaslan
added
the
new ui
|
Will review... |
mcgilman
reviewed
May 3, 2024
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! Looks great! Noted a few things below. I only commented them for the prioritizers, but my comments also apply to the parameter contexts since they are implemented similarly. I did not duplicate my comments.
.../app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html
Outdated
Show resolved
Hide resolved
.../app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html
Outdated
Show resolved
Hide resolved
.../app/pages/flow-designer/ui/canvas/items/connection/prioritizers/prioritizers.component.html
Show resolved
Hide resolved
mcgilman
reviewed
May 3, 2024
...ter-context-listing/parameter-context-inheritance/parameter-context-inheritance.component.ts
Outdated
Show resolved
Hide resolved
mcgilman
approved these changes
May 3, 2024
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-12903] style updates for drag/drop UX * restore nf-editor styles * remove padding from new canvas items * remove unused disabled * no value set UX * restore initial disabled state This closes apache#8729
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-12903] style updates for drag/drop UX * restore nf-editor styles * remove padding from new canvas items * remove unused disabled * no value set UX * restore initial disabled state This closes apache#8729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates reuseable styles for all cdk drag/drop UX. Please test with connection prioritizers as well as parameter context inheritence.