[NIFI-13104] Unknown Route handling #8725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n HttpErrorResponse object
rfellows
added
the
new ui
|
Reviewing... |
mcgilman
reviewed
May 2, 2024
There was a problem hiding this comment.
Thanks for the PR @rfellows! The fixes around the unmatched route looks good. I did not one minor suggestion below to help with readability.
I did however notice a number of additional instances that should be using the new getErrorString helper method. If you search for errorResponse.error and error.error with in this module I think you'll find a few more spots that need updating.
Comment on lines
84
to
88
| if (errorResponse.error && errorResponse.status !== 0) { | ||
| errorMessage = errorResponse.error; | ||
| } else if (!errorResponse.error && errorResponse.status !== 0) { | ||
| errorMessage = errorResponse.message || `${errorResponse.status}`; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (errorResponse.error && errorResponse.status !== 0) { | |
| errorMessage = errorResponse.error; | |
| } else if (!errorResponse.error && errorResponse.status !== 0) { | |
| errorMessage = errorResponse.message || `${errorResponse.status}`; | |
| } | |
| if (errorResponse.status !== 0) { | |
| if (errorResponse.error) { | |
| errorMessage = errorResponse.error; | |
| } else { | |
| errorMessage = errorResponse.message || `${errorResponse.status}`; | |
| } | |
| } |
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-13104] - Unknown route handling * Add method to the ErrorHelper that safely gets an error string from an HttpErrorResponse object * review feedback * use errorHelper.fullScreenError in favor of directly calling the fullScreenError action This closes apache#8725
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-13104] - Unknown route handling * Add method to the ErrorHelper that safely gets an error string from an HttpErrorResponse object * review feedback * use errorHelper.fullScreenError in favor of directly calling the fullScreenError action This closes apache#8725
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-13104