This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
1.9.RC6 Licensing Issues #20475
Comments
Thanks @josephevans . @szha will you help to address the license issues? |
@josephevans thanks for driving this forward |
8 tasks
6 tasks
2 tasks
PR for item 6 - #20520 |
Thanks everyone for helping with these license issues. All items have been fixed and merged. |
@josephevans thanks for driving the fix for these license issues! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Based on feedback from the general@incubator 1.9 rc6 release vote, we have some issues with licensing to address.
Vote thread and feedback: https://lists.apache.org/thread.html/rb60ab16d34f7c019fdc63fd99a34bc61c099eb480cb407c1f1905e30%40%3Cgeneral.incubator.apache.org%3E
I've compiled the feedback into a list of action items. If you can assist in tackling one of these items, please coordinate in the comments on this issue.
Action Items
1. The following files have an ASF header but is listed as MIT in LICENSE file. We need to determine what the files are actually licensed as and ensure the header and LICENSE files reflect this.
src/operator/nn/layer_norm.cc
src/operator/numpy/np_einsum_op.cc
src/operator/numpy/np_einsum_op-inl.h
src/operator/numpy/np_einsum_path_op-inl.h
License issue with src/operator/contrib/erfinv-inl.h #20511
This file has a comment that states "Code is a direct translation of the erfinv m file in matlab version 2.0.” and the GitHub reference doesn't have a BSD file header. As far as I’m aware Matlab is not open source software. Is this Category X software?
This files seem to have incorrect licensing information [13] At the URL referenced it has a different header. I can’t see why the ASF copyright would be in this header.
License issue with example/image-classification/predict-cpp/image-classification-predict.cc #20515
example/image-classification/predict-cpp/image-classification-predict.cc
4. These files seem to incorrectly have an ASF header
python/mxnet/onnx/mx2onnx/_export_onnx.py
cmake/Modules/FindJeMalloc.cmake
src/operator/nn/mkldnn/mkldnn_base-inl.h
5. A large number of file have ASF headers but also state "Copyright (c) 201X by Contributors”. e.g [1][2][3][4] There looks to be more than 500 files like this. Are these 3rd party file or ASF files? If they are ASF files there there should be no copyright line. Examples:
include/mxnet/op_attr_types.h
cpp-package/include/mxnet-cpp/op_suppl.h
src/initialize.cc
src/operator/cudnn_bilinear_sampler-inl.h
6. A number of files have "Copyright (c) 201X Microsoft” and also have ASF headers. Are these files 3rd party files or ASF files? e.g. [11] They look like 3rd party files to me. Some are Apache licensed but some are not. e.g [12] I cannot see this mentioned in LICENSE.
11: src/operator/contrib/deformable_psroi_pooling.cu
12: src/operator/contrib/modulated_deformable_convolution.cu
7. I also noticed that the docker file refreshes to https://github.com/dmlc/mxnet Why is this? In fact there seems to be a large number of references to "https://github.com/dmlc” (https://github.com/dmlc) and "https://github.com/dmlc/mxnet". (https://github.com/dmlc/mxnet.)
The text was updated successfully, but these errors were encountered: