You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Let's deprecate USE_PROFILER from cmake and build systems as this flag is now always on at compile time. Having this option seems to be confusing users. Doing a full removal from cmake should be safe, and should present users with an intuitive message. For other build systems we may need to provide a deprecation message.
The text was updated successfully, but these errors were encountered:
Yes, it's not used for make as well. It can be safely removed. The only usage of USE_PROFILER in the repo are in build scripts and documentation currently.
I think we still have to remove this option from our codebase right? I see a lot of documentation wrongly instructing users to set it to true for an example.
Let's deprecate USE_PROFILER from cmake and build systems as this flag is now always on at compile time. Having this option seems to be confusing users. Doing a full removal from cmake should be safe, and should present users with an intuitive message. For other build systems we may need to provide a deprecation message.
The text was updated successfully, but these errors were encountered: