From 40459bd51b701bccbad3f673724364a027de3e5e Mon Sep 17 00:00:00 2001
From: zoeygxy <zoey.gxy@gmail.com>
Date: Fri, 23 Aug 2019 16:12:59 +0800
Subject: [PATCH] disable CHECK; fix style

---
 3rdparty/mshadow/mshadow/extension/slice.h |  5 ++---
 python/mxnet/ndarray/numpy/_op.py          | 22 +---------------------
 src/c_api/c_api.cc                         |  4 ++--
 3 files changed, 5 insertions(+), 26 deletions(-)

diff --git a/3rdparty/mshadow/mshadow/extension/slice.h b/3rdparty/mshadow/mshadow/extension/slice.h
index 20a6b8c4e223..1dd88140a93f 100644
--- a/3rdparty/mshadow/mshadow/extension/slice.h
+++ b/3rdparty/mshadow/mshadow/extension/slice.h
@@ -33,9 +33,8 @@ struct SliceExp : public TRValue<SliceExp<SrcExp,
       : src_(src), ch_begin_(begin) {
     shape_ = ShapeCheck<srcdim, SrcExp>::Check(src_);
     ch_old_ = shape_[dimslice];
-    CHECK(begin <= shape_[dimslice] && end <= shape_[dimslice])
-        << "The slice went out of range. dimslice: " << dimslice << "; shape = "
-        << shape_ << "; begin = " << begin << "; end = " << end;
+    // CHECK(begin <= shape_[dimslice] && end <= shape_[dimslice])
+    //     << "The slice went out of range. ";  // TODO(zoeygxy)
     shape_[dimslice] = end - begin;
   }
   template<typename E, int etype>
diff --git a/python/mxnet/ndarray/numpy/_op.py b/python/mxnet/ndarray/numpy/_op.py
index eafa93fc5a36..dac7a91d85ab 100644
--- a/python/mxnet/ndarray/numpy/_op.py
+++ b/python/mxnet/ndarray/numpy/_op.py
@@ -27,8 +27,7 @@
 from ..ndarray import NDArray
 
 __all__ = ['zeros', 'ones', 'add', 'subtract', 'multiply', 'divide', 'mod', 'power', 'tensordot',
-           'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack', 'full',
-           'slice_assign_scalar', 'slice_assign']
+           'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack', 'full']
 
 
 @set_module('mxnet.ndarray.numpy')
@@ -783,22 +782,3 @@ def get_list(arrays):
 
     arrays = get_list(arrays)
     return _npi.stack(*arrays, axis=axis, out=out)
-
-
-@set_module('mxnet.ndarray.numpy')
-def slice_assign_scalar(lhs, value, begin, end, step, out=None):  # pylint: disable=too-many-arguments
-    """
-    Assign the rhs to a cropped subset of this ndarray in place. Returns the view of this ndarray.
-    `rhs` and `lhs` should be of the same data type, and on the same device.
-    The shape of rhs should be the same as the cropped shape of this ndarray.
-    """
-    _npi.slice_assign_scalar(lhs, value, begin=begin, end=end, step=step, out=out)
-
-
-@set_module('mxnet.ndarray.numpy')
-def slice_assign(lhs, rhs, begin, end, step, out=None):  # pylint: disable=too-many-arguments
-    """
-    Assign the scalar to a cropped subset of this ndarray. Value will broadcast to the shape of the
-    cropped shape and will be cast to the same dtype of the ndarray.
-    """
-    return _npi.slice_assign(lhs, rhs, begin=begin, end=end, step=step, out=out)
diff --git a/src/c_api/c_api.cc b/src/c_api/c_api.cc
index 3ccebf2d8aab..4f627f84f47d 100644
--- a/src/c_api/c_api.cc
+++ b/src/c_api/c_api.cc
@@ -543,8 +543,8 @@ MXNET_DLL int MXNDArrayReshape64(NDArrayHandle handle,
   API_BEGIN();
   NDArray *arr = static_cast<NDArray*>(handle);
   mxnet::Tuple<dim_t> shape(dims, dims+ndim);
-  CHECK_GE(arr->shape().Size(), 0) << "Source ndarray's shape is undefined. Input shape: "
-    << arr->shape();
+  // CHECK_GE(arr->shape().Size(), 0) << "Source ndarray's shape is undefined. Input shape: "
+  //   << arr->shape();  // TODO(zoeygxy)
   mxnet::TShape new_shape = mxnet::op::InferReshapeShape(shape, arr->shape(), reverse);
   *ptr = arr->ReshapeWithRecord(new_shape);
   *out = ptr;