Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop max-parallel from GitHub build #455

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Feb 2, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@Tibor17
Copy link
Contributor Author

Tibor17 commented Feb 2, 2022

@slawekjaranowski
Your commit is higly needed.
Can we proceed with this PR? Do you want to add something into it?

The reason why I used the latest JDK 18 for ff was the fact that new issues (similar to a problem with SecurityManager) can be discovered with latest JDK version. Therefore I used ff-jdk: '18-ea'.

@slawekjaranowski
Copy link
Member

Finished - can be merged.

@slawekjaranowski slawekjaranowski merged commit 33ccb25 into master Feb 2, 2022
@slawekjaranowski slawekjaranowski deleted the gh-drop-max-parallel branch February 2, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants