Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes starts more threads than it should? #362

Closed
famod opened this issue Feb 16, 2021 · 4 comments
Closed

Sometimes starts more threads than it should? #362

famod opened this issue Feb 16, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@famod
Copy link
Contributor

famod commented Feb 16, 2021

This might just be a display glitch, but sometimes when building Quarkus I can see something like: threads used/hidden/max: 8/0/7
This is on WSL2/Ubuntu 20.04.

In WSL1/Ubuntu 20.04 on my rather dated work laptop it even reaches threads used/hidden/max: 12/0/7.
When this happens the list of modules being built is actually that long (longer than it should be).

@gnodet
Copy link
Contributor

gnodet commented Feb 23, 2021

I think logging statements may still be associated with a given project after it has been finished. The client should disassociate those if they are sent after the project's build is finished.

@gnodet gnodet added the bug Something isn't working label Feb 23, 2021
@ppalaga
Copy link
Contributor

ppalaga commented Feb 23, 2021

What do you mean with "disassociate"? - not show them at all in the threaded view?

@gnodet
Copy link
Contributor

gnodet commented Feb 23, 2021

What do you mean with "disassociate"? - not show them at all in the threaded view?

Yes, they would be associated to the main log instead of the per project log.
The way the log are associated to projects is not 100% perfect, because of the lacking infrastructure in maven, so mvnd does its best. Also ordering of the messages may be wrong : if the project's finish message arrives before one of the log, the client will recreate the project and it will kept in the display forever.

@gnodet
Copy link
Contributor

gnodet commented Mar 5, 2021

Fixed by #367

@gnodet gnodet closed this as completed Mar 5, 2021
@gnodet gnodet self-assigned this Mar 5, 2021
@gnodet gnodet added this to the 0.4.2 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants