Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing random test seed/culture: en-IE with seed 0x9a2b7430d6d33f0d #998

Open
1 task done
paulirwin opened this issue Oct 25, 2024 · 1 comment
Open
1 task done
Labels
is:bug pri:normal test-failure up-for-grabs This issue is open to be worked on by anyone

Comments

@paulirwin
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Found a random failing test seed/culture pair. Set the following in a lucene.testsettings.json file in your repo root (or somewhere between the test executable and the root of your drive):

{
  "tests": {
     "seed": "0x9a2b7430d6d33f0d",
     "culture": "en-IE"
  }
}

This causes the following tests to fail on these frameworks:

Lucene.Net.Index.TestIndexReaderClose.TestCloseUnderException() (net5.0, net48, net472)

Message:

System.ArgumentException : The supplied DateTime represents an invalid time. For example, when the clock is adjusted forward, any time in the period that is skipped is invalid. (Parameter 'dateTime')

Lucene.Net.Util.Events.TestPubSubEvent.CanAddSubscriptionWhileEventIsFiringNonGeneric() (net472)

Message:

Expected: True Actual: False

Lucene.Net.Analysis.Icu.TestICUNormalizer2CharFilter.TestRandomStrings() (net5.0, net48)

Message:

Lucene.Net.Diagnostics.AssertionException : End() called before IncrementToken() returned false!

Expected Behavior

The tests all pass.

Steps To Reproduce

No response

Exceptions (if any)

No response

Lucene.NET Version

4.8.0-beta00017

.NET Version

Various (listed above)

Operating System

Windows

Anything else?

x64 platform, running ./build.ps1 -t

@paulirwin paulirwin added is:bug up-for-grabs This issue is open to be worked on by anyone test-failure labels Oct 25, 2024
@paulirwin paulirwin added this to the 4.8.0 milestone Oct 25, 2024
@NightOwl888
Copy link
Contributor

Lucene.Net.Util.Events.TestPubSubEvent.CanAddSubscriptionWhileEventIsFiringNonGeneric()

I think we should [Ignore] this one. This is a test we inherited when we brought over the code from Prism.Core (which went commercial), and it has always been flakey. But we haven't had any complaints from .NET Framework or .NET Standard 2.0 users that these weak events are failing or causing any other issues.

It is a workaround for when ConditionalWeakTable<TKey, TValue> had no enumerator, so we use weak events to fake it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug pri:normal test-failure up-for-grabs This issue is open to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants