Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): all blocking commands should be no-script #2666

Merged
merged 3 commits into from
Nov 16, 2024
Merged

feat(cmd): all blocking commands should be no-script #2666

merged 3 commits into from
Nov 16, 2024

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Nov 15, 2024 •
edited
Loading

As the title, all blocking commands should be no-script.

@PragmaTwice PragmaTwice requested a review from git-hulk November 15, 2024 14:56
git-hulk
git-hulk previously approved these changes Nov 15, 2024
View reviewed changes
torwig
torwig previously approved these changes Nov 15, 2024
View reviewed changes
@PragmaTwice PragmaTwice dismissed stale reviews from torwig and git-hulk via 13701da November 16, 2024 04:52
@PragmaTwice PragmaTwice changed the title feat(cmd): all blocking commands should be no-multi and no-script feat(cmd): all blocking commands should be no-script Nov 16, 2024
@PragmaTwice PragmaTwice merged commit cc4f63d into apache:unstable Nov 16, 2024
31 checks passed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
60.9% Coverage on New Code
1.3% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@git-hulk git-hulk git-hulk approved these changes

@torwig torwig torwig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PragmaTwice @git-hulk @torwig