We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently our ci checks clang-format. We can add a checking in git hook for that.
Aadd a checking in git hook for format
The text was updated successfully, but these errors were encountered:
I guess we could hard link pre-push.sh to .git/hooks/pre-push during x.py build.
pre-push.sh
.git/hooks/pre-push
x.py build
For example:
https://github.com/rust-lang/rust/blob/faefc618cf48bd794cbc808448df1bf3f59f36af/src/bootstrap/src/core/build_steps/setup.rs#L511-L522
However, I'm unsure about the directory in the project where the pre-push.sh source code should be placed.
Sorry, something went wrong.
If convenient, you can add other checks at the same time, such as golang format, clang tidy
At root or some build scripts might be ok
clang tidy
clang-tidy is time-consuming, I guess puting it at ci or by-user is better
/assign
Successfully merging a pull request may close this issue.
Search before asking
Motivation
Currently our ci checks clang-format. We can add a checking in git hook for that.
Solution
Aadd a checking in git hook for format
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: