-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce the number of write buffers for infrequently used column families #2193
Comments
Please assign it to me, thanks a lot :D |
@LiuYuHui Thank you! |
Hi @LiuYuHui Are you still working on this issue? |
Hi @git-hulk, I have had no extra time bandwidth recently, please feel free to assign it to other people. |
@LiuYuHui Thanks for your quick response. Welcome back while you get time. |
Hi @git-hulk , May i question? How do we implement this feature?
rocksdb::BlockBasedTableOptions lite_table_opts = InitTableOptions();
rocksdb::ColumnFamilyOptions lite_opts(subkey_opts);
lite_opts.write_buffer_size = 32 * MiB;
lite_opts.max_write_buffer_number = 0;
// replace subkey_opts with lite_opts
column_families.emplace_back(kZSetScoreColumnFamilyName, lite_opts);
column_families.emplace_back(kPubSubColumnFamilyName, lite_opts);
column_families.emplace_back(kPropagateColumnFamilyName, lite_opts);
column_families.emplace_back(kStreamColumnFamilyName, lite_opts);``` |
@jjz921024 Yes, I'm good with this implementation. Would you like to submit a PR? |
Yes, I want to try |
@jjz921024 Assigned, thank you! |
Search before asking
Motivation
Currently, all column families are shared the same number of write buffers
which is unnecessary for infrequently used column families including
pubsub
,propagte
, andzset_score
. We can keep them to a const value like 1 to reducethe memory usage in some scenarios.
Solution
No response
Are you willing to submit a PR?
The text was updated successfully, but these errors were encountered: